Optimize sampling for empty images #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be cleaner to add a check at the start of resize to immediately return |
HeroicKatora
force-pushed
the
issue-2340
branch
from
f6baa5e
to
2978612
Compare
This is a tip of an iceberg of better sampling, but the most critical case. Up-sampling in general may in the implementation allocate a larger temporary buffer than its input. Of course this makes little semantic sense here: after all, the actual information can not increase by this. If one dimension increases while the other decreases the unfortunate consequence is that callers may somewhat reasonably expect a small buffer but internally will get a very large buffer. The approach of swapping sampling orders accordingly (first down, then up) might address the memory issue but is lossy. So instead let's fix the most pressing issue: if no information was present in the input, nothing can be lost and we can pretend to perform everything by a very small intermediate image.
HeroicKatora
force-pushed
the
issue-2340
branch
from
2978612
to
15b6e87
Compare
kornelski
approved these changes
Oct 11, 2024
okaneco
reviewed
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tip of an iceberg of better sampling, but the most critical case. Up-sampling in general may in the implementation allocate a larger temporary buffer than its input. Of course this makes little semantic sense here: after all, the actual information can not increase by this.
If one dimension increases while the other decreases the unfortunate consequence is that callers may somewhat reasonably expect a small buffer but internally will get a very large buffer. The approach of swapping sampling orders accordingly (first down, then up) might address the memory issue but is lossy.
So instead let's fix the most pressing issue: if no information was present in the input, nothing can be lost and we can pretend to perform everything by a very small intermediate image.
closes: #2340